[Asterisk-code-review] app.c: make sure that no non-async-signal-safe syscalls are used afte... (asterisk[16])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14209 )

Change subject: app.c: make sure that no non-async-signal-safe syscalls are used after fork before exec
......................................................................


Patch Set 2: Code-Review-1

(6 comments)

https://gerrit.asterisk.org/c/asterisk/+/14209/2/main/strcompat.c 
File main/strcompat.c:

https://gerrit.asterisk.org/c/asterisk/+/14209/2/main/strcompat.c@437 
PS2, Line 437: 
             : 	if (maxfd == -1)
             : 		maxfd = 1024;
             : 	if (maxfd > 65536)
             : 		maxfd = 65536;
Put a comment here stating why these numbers are used.

Also surround each 'if' with brackets.


https://gerrit.asterisk.org/c/asterisk/+/14209/2/main/strcompat.c@443 
PS2, Line 443: 	while (fd<maxfd) {
Coding guidelines: put a space before/after '<'


https://gerrit.asterisk.org/c/asterisk/+/14209/2/main/strcompat.c@445 
PS2, Line 445: 		if (loopmax>POLL_SIZE) {
spaces before/after '>'


https://gerrit.asterisk.org/c/asterisk/+/14209/2/main/strcompat.c@448 
PS2, Line 448: 		for (i=0;i<loopmax;i++) {
spacing between elements here too.


https://gerrit.asterisk.org/c/asterisk/+/14209/2/main/strcompat.c@453 
PS2, Line 453: 		for (i=0;i<loopmax;i++) {
fix element spacing here as well.


https://gerrit.asterisk.org/c/asterisk/+/14209/2/main/strcompat.c@471 
PS2, Line 471: 		fd+=loopmax;
space before/after '+='



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14209
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: Idc76365c0592ee3f3b3bd72a4f48f7a098978e8e
Gerrit-Change-Number: 14209
Gerrit-PatchSet: 2
Gerrit-Owner: nappsoft <infos at nappsoft.ch>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-CC: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Tue, 21 Apr 2020 21:16:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200421/4475cd0c/attachment-0001.html>