<p>Patch set 2:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/14209">View Change</a></p><p>6 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/14209/2/main/strcompat.c">File main/strcompat.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14209/2/main/strcompat.c@437">Patch Set #2, Line 437:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><br> if (maxfd == -1)<br> maxfd = 1024;<br> if (maxfd > 65536)<br> maxfd = 65536;<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Put a comment here stating why these numbers are used.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Also surround each 'if' with brackets.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14209/2/main/strcompat.c@443">Patch Set #2, Line 443:</a> <code style="font-family:monospace,monospace"> while (fd<maxfd) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Coding guidelines: put a space before/after '<'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14209/2/main/strcompat.c@445">Patch Set #2, Line 445:</a> <code style="font-family:monospace,monospace"> if (loopmax>POLL_SIZE) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">spaces before/after '>'</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14209/2/main/strcompat.c@448">Patch Set #2, Line 448:</a> <code style="font-family:monospace,monospace"> for (i=0;i<loopmax;i++) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">spacing between elements here too.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14209/2/main/strcompat.c@453">Patch Set #2, Line 453:</a> <code style="font-family:monospace,monospace"> for (i=0;i<loopmax;i++) {</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">fix element spacing here as well.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/14209/2/main/strcompat.c@471">Patch Set #2, Line 471:</a> <code style="font-family:monospace,monospace"> fd+=loopmax;</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">space before/after '+='</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/14209">change 14209</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/14209"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: Idc76365c0592ee3f3b3bd72a4f48f7a098978e8e </div>
<div style="display:none"> Gerrit-Change-Number: 14209 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: nappsoft <infos@nappsoft.ch> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-CC: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 21 Apr 2020 21:16:53 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>