[Asterisk-code-review] core: Fix NPE in ast_manager_build_channel_state_string when snapshot... (asterisk[16])

[Robert Sutton]

Hello Sean Bright, Friendly Automation, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/14144

to look at the new patch set (#3).

Change subject: core: Fix NPE in ast_manager_build_channel_state_string when snapshot is NULL
......................................................................

core: Fix NPE in ast_manager_build_channel_state_string when snapshot is NULL

There appear to be more than 10 paths where a snapshot is passed to
ast_manager_build_channel_state_string without checking that it is not NULL.

While they could be fixed, it would only lead to re-occurances of this
problem in the future.

As ast_manager_build_channel_state_string may normally return NULL,
a NULL check on snapshot has been added and the method will
return NULL if snapshot is NULL.

A WARNING level log has also been added to help with debugging any future
secondary issues that might arrise.

ASTERISK-28810

Change-Id: I3393e4d521ab6c4551b5434d013a5941706c28de
---
M main/manager_channels.c
1 file changed, 5 insertions(+), 0 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/44/14144/3
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14144
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I3393e4d521ab6c4551b5434d013a5941706c28de
Gerrit-Change-Number: 14144
Gerrit-PatchSet: 3
Gerrit-Owner: Robert Sutton <rsutton at noojee.com.au>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200414/7398e314/attachment-0001.html>