[Asterisk-code-review] core: Fix NPE in ast_manager_build_channel_state_string when snapshot... (asterisk[16])

[Robert Sutton]

Robert Sutton has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/14144 )

Change subject: core: Fix NPE in ast_manager_build_channel_state_string when snapshot is NULL
......................................................................


Patch Set 2:

> Patch Set 1:
> 
> > Patch Set 1: Code-Review-1
> > 
> > (1 comment)
> > 
> > Adding this NULL check will stop the crash, but my question is: why are we passing NULL snapshots? Is that OK?
> 
> I have the same questions. The core problem hasn't really been identified or explained. This NULL check can just end up hiding a larger issue, instead of solving it.

Following the instructions on "Updating a Review", whilst I managed to amend my commit and update this review I encountered a problem with the instructions.

when I issued this command
    git review -d 28810
It gave this response
    Could not fetch review information for change 28810


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/14144
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I3393e4d521ab6c4551b5434d013a5941706c28de
Gerrit-Change-Number: 14144
Gerrit-PatchSet: 2
Gerrit-Owner: Robert Sutton <rsutton at noojee.com.au>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-CC: Joshua Colp <jcolp at sangoma.com>
Gerrit-Comment-Date: Tue, 14 Apr 2020 23:22:26 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20200414/f73f9b74/attachment.html>