[Asterisk-code-review] channel/chan_pjsip: add dialplan function for music on hold (...asterisk[13])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/12893 )

Change subject: channel/chan_pjsip: add dialplan function for music on hold
......................................................................


Patch Set 5: Code-Review-1

(4 comments)

https://gerrit.asterisk.org/#/c/12893/5/channels/pjsip/dialplan_functions.c 
File channels/pjsip/dialplan_functions.c:

https://gerrit.asterisk.org/#/c/12893/5/channels/pjsip/dialplan_functions.c@92 
PS5, Line 92: 		<para>If <replaceable>yes</replaceable> on-hold re-INVITES are sent If<replaceable>no</replaceable>, music on hold is generated.</para>
Replace with the following:

 <para>If <replaceable>yes</replaceable>, on-hold re-INVITEs are sent. If <replaceable>no</replaceable>, music on hold is generated.</para>


https://gerrit.asterisk.org/#/c/12893/5/channels/pjsip/dialplan_functions.c@93 
PS5, Line 93: 		<para>This function can be used to override the moh_passthrough configuration option</para>
Probably should end with "on an endpoint." (I haven't looked closely enough to know what it is overriding to say definitively)


https://gerrit.asterisk.org/#/c/12893/5/channels/pjsip/include/dialplan_functions.h 
File channels/pjsip/include/dialplan_functions.h:

https://gerrit.asterisk.org/#/c/12893/5/channels/pjsip/include/dialplan_functions.h@151 
PS5, Line 151: #endif /* _PJSIP_DIALPLAN_FUNCTIONS */
Needless whitespace change


https://gerrit.asterisk.org/#/c/12893/5/doc/CHANGES-staging/chan_pjsip_moh_passthrough.txt 
File doc/CHANGES-staging/chan_pjsip_moh_passthrough.txt:

https://gerrit.asterisk.org/#/c/12893/5/doc/CHANGES-staging/chan_pjsip_moh_passthrough.txt@3 
PS5, Line 3: A new dialplan function PJSIP_MOH_PASSTRHOUGH has been added to chan_pjsip. This
Very nit-picky considering it's just a CHANGES entry, but there should be commas around the function name, e.g.:

 ... function, PJSIP_MOH_PASSTHROUGH, has been ...



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/12893
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: Iebe905b2ad6dbaa87ab330267147180b05a3c3a8
Gerrit-Change-Number: 12893
Gerrit-PatchSet: 5
Gerrit-Owner: Torrey Searle <tsearle at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Mon, 30 Sep 2019 20:32:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190930/5d61f8e2/attachment.html>