<p>Patch set 5:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/12893">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/12893/5/channels/pjsip/dialplan_functions.c">File channels/pjsip/dialplan_functions.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/12893/5/channels/pjsip/dialplan_functions.c@92">Patch Set #5, Line 92:</a> <code style="font-family:monospace,monospace">         <para>If <replaceable>yes</replaceable> on-hold re-INVITES are sent If<replaceable>no</replaceable>, music on hold is generated.</para></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Replace with the following:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> <para>If <replaceable>yes</replaceable>, on-hold re-INVITEs are sent. If <replaceable>no</replaceable>, music on hold is generated.</para></pre></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/12893/5/channels/pjsip/dialplan_functions.c@93">Patch Set #5, Line 93:</a> <code style="font-family:monospace,monospace">         <para>This function can be used to override the moh_passthrough configuration option</para></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Probably should end with "on an endpoint." (I haven't looked closely enough to know what it is overriding to say definitively)</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/12893/5/channels/pjsip/include/dialplan_functions.h">File channels/pjsip/include/dialplan_functions.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/12893/5/channels/pjsip/include/dialplan_functions.h@151">Patch Set #5, Line 151:</a> <code style="font-family:monospace,monospace">#endif /* _PJSIP_DIALPLAN_FUNCTIONS */</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Needless whitespace change</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/12893/5/doc/CHANGES-staging/chan_pjsip_moh_passthrough.txt">File doc/CHANGES-staging/chan_pjsip_moh_passthrough.txt:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/12893/5/doc/CHANGES-staging/chan_pjsip_moh_passthrough.txt@3">Patch Set #5, Line 3:</a> <code style="font-family:monospace,monospace">A new dialplan function PJSIP_MOH_PASSTRHOUGH has been added to chan_pjsip. This</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Very nit-picky considering it's just a CHANGES entry, but there should be commas around the function name, e.g.:</p><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> ... function, PJSIP_MOH_PASSTHROUGH, has been ...</pre></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/12893">change 12893</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/12893"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-Change-Id: Iebe905b2ad6dbaa87ab330267147180b05a3c3a8 </div>
<div style="display:none"> Gerrit-Change-Number: 12893 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: Torrey Searle <tsearle@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 30 Sep 2019 20:32:38 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>