[Asterisk-code-review] app_amd: Fixed timeout issue (asterisk[13])

[Michael Cargile]

Michael Cargile has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13161 )

Change subject: app_amd: Fixed timeout issue
......................................................................


Patch Set 7:

(6 comments)

> Patch Set 7: Code-Review+1
> 
> Please cherry pick this to the 16, 17, and master branches.

Done.

https://gerrit.asterisk.org/c/asterisk/+/13161/5//COMMIT_MSG 
Commit Message:

https://gerrit.asterisk.org/c/asterisk/+/13161/5//COMMIT_MSG@9 
PS5, Line 9: ASTERISK-28143 attempted to fix an issue where calls with no audio would never
> Reverences to other issues should replace the - with either ~ or _. […]
Done


https://gerrit.asterisk.org/c/asterisk/+/13161/5//COMMIT_MSG@15 
PS5, Line 15: 
> Per the wiki: […]
Done


https://gerrit.asterisk.org/c/asterisk/+/13161/5/apps/app_amd.c 
File apps/app_amd.c:

https://gerrit.asterisk.org/c/asterisk/+/13161/5/apps/app_amd.c@308 
PS5, Line 308: 				ast_verb(3, "AMD: Channel [%s]. No audio date recieved in [%d] seconds.\n", ast_channel_name(chan), totalAnalysisTime);
> "date recieved" -> "data received"
Done


https://gerrit.asterisk.org/c/asterisk/+/13161/5/apps/app_amd.c@317 
PS5, Line 317: 		if (f->frametype == AST_FRAME_VOICE || f->frametype == AST_FRAME_CNG) {
> Was removing the "f->frametype == AST_FRAME_NULL" intentional?
Yes. This was added in ASTERISK-28143 to try to solve an issue where app_amd.so would never timeout on calls with no audio data. The problem is AST_FRAME_NULL frames seem to show up more often than AST_FRAME_VOICE or AST_FRAME_CNG. As such by including it in the calculations it results in app_amd.so timing out too quickly. I have seen instances where the timeout is set to five seconds but the call times out in under one.


https://gerrit.asterisk.org/c/asterisk/+/13161/5/apps/app_amd.c@319 
PS5, Line 319:                         audioFrameCount++;
> Too much leading whitespace. Should be lined up with the comment on the previous line.
Done


https://gerrit.asterisk.org/c/asterisk/+/13161/6/apps/app_amd.c 
File apps/app_amd.c:

https://gerrit.asterisk.org/c/asterisk/+/13161/6/apps/app_amd.c@308 
PS6, Line 308: 				ast_verb(3, "AMD: Channel [%s]. No audio data recieved in [%d] seconds.\n", ast_channel_name(chan), totalAnalysisTime);
> "recieved" -> "received" […]
Not nit-picky. I completely missed that.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13161
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I642a21b02d389b17e40ccd5357754b034c3daa42
Gerrit-Change-Number: 13161
Gerrit-PatchSet: 7
Gerrit-Owner: Michael Cargile <mikec at vicidial.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-CC: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Tue, 19 Nov 2019 16:40:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Sean Bright <sean.bright at gmail.com>
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Comment-In-Reply-To: Richard Mudgett <rmudgett at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191119/00b4a823/attachment-0001.html>