<blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Patch Set 7: Code-Review+1</p><p style="white-space: pre-wrap; word-wrap: break-word;">Please cherry pick this to the 16, 17, and master branches.</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">Done.</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13161">View Change</a></p><p>6 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13161/5//COMMIT_MSG">Commit Message:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/13161/5//COMMIT_MSG@9">Patch Set #5, Line 9:</a> <code style="font-family:monospace,monospace">ASTERISK-28143 attempted to fix an issue where calls with no audio would never</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Reverences to other issues should replace the - with either ~ or _. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/13161/5//COMMIT_MSG@15">Patch Set #5, Line 15:</a> <code style="font-family:monospace,monospace"></code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Per the wiki: […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13161/5/apps/app_amd.c">File apps/app_amd.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/13161/5/apps/app_amd.c@308">Patch Set #5, Line 308:</a> <code style="font-family:monospace,monospace"> ast_verb(3, "AMD: Channel [%s]. No audio date recieved in [%d] seconds.\n", ast_channel_name(chan), totalAnalysisTime);</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">"date recieved" -> "data received"</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/13161/5/apps/app_amd.c@317">Patch Set #5, Line 317:</a> <code style="font-family:monospace,monospace"> if (f->frametype == AST_FRAME_VOICE || f->frametype == AST_FRAME_CNG) {</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Was removing the "f->frametype == AST_FRAME_NULL" intentional?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Yes. This was added in ASTERISK-28143 to try to solve an issue where app_amd.so would never timeout on calls with no audio data. The problem is AST_FRAME_NULL frames seem to show up more often than AST_FRAME_VOICE or AST_FRAME_CNG. As such by including it in the calculations it results in app_amd.so timing out too quickly. I have seen instances where the timeout is set to five seconds but the call times out in under one.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/13161/5/apps/app_amd.c@319">Patch Set #5, Line 319:</a> <code style="font-family:monospace,monospace"> audioFrameCount++;</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Too much leading whitespace. Should be lined up with the comment on the previous line.</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Done</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13161/6/apps/app_amd.c">File apps/app_amd.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/13161/6/apps/app_amd.c@308">Patch Set #6, Line 308:</a> <code style="font-family:monospace,monospace"> ast_verb(3, "AMD: Channel [%s]. No audio data recieved in [%d] seconds.\n", ast_channel_name(chan), totalAnalysisTime);</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">"recieved" -> "received" […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Not nit-picky. I completely missed that.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/13161">change 13161</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/13161"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-Change-Id: I642a21b02d389b17e40ccd5357754b034c3daa42 </div>
<div style="display:none"> Gerrit-Change-Number: 13161 </div>
<div style="display:none"> Gerrit-PatchSet: 7 </div>
<div style="display:none"> Gerrit-Owner: Michael Cargile <mikec@vicidial.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-CC: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 19 Nov 2019 16:40:17 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Comment-In-Reply-To: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Comment-In-Reply-To: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>