[Asterisk-code-review] app_senddtmf: Add receive mode to AMI Action PlayDTMF (testsuite[16])

[Benjamin Keith Ford]

Benjamin Keith Ford has posted comments on this change. ( https://gerrit.asterisk.org/c/testsuite/+/13164 )

Change subject: app_senddtmf: Add receive mode to AMI Action PlayDTMF
......................................................................


Patch Set 1: Code-Review-1

(5 comments)

https://gerrit.asterisk.org/c/testsuite/+/13164/1/tests/manager/playdtmf/sipp/invite.xml 
File tests/manager/playdtmf/sipp/invite.xml:

https://gerrit.asterisk.org/c/testsuite/+/13164/1/tests/manager/playdtmf/sipp/invite.xml@7 
PS1, Line 7:             INVITE sip:dialplan@[remote_ip]:[remote_port] SIP/2.0
           :             Via: SIP/2.0/[transport] [local_ip]:[local_port];branch=[branch]
           :             From: "alice" <sip:alice@[local_ip]:[local_port]>;tag=[call_number]
           :             To: "bob" <sip:dialplan@[remote_ip]:[remote_port]>
           :             Call-ID: [call_id]
           :             CSeq: [cseq] INVITE
           :             Contact: sip:alice@[local_ip]:[local_port]
           :             Max-Forwards: 70
           :             Content-Type: application/sdp
           :             Content-Length: [len]
Use tab spacing


https://gerrit.asterisk.org/c/testsuite/+/13164/1/tests/manager/playdtmf/sipp/invite.xml@46 
PS1, Line 46:                         Allow: INVITE, ACK, MESSAGE, BYE
Tab spacing


https://gerrit.asterisk.org/c/testsuite/+/13164/1/tests/manager/playdtmf/sipp/invite.xml@64 
PS1, Line 64:                         Allow: INVITE, ACK, MESSAGE, BYE
Tab spacing


https://gerrit.asterisk.org/c/testsuite/+/13164/1/tests/manager/playdtmf/test-config.yaml 
File tests/manager/playdtmf/test-config.yaml:

https://gerrit.asterisk.org/c/testsuite/+/13164/1/tests/manager/playdtmf/test-config.yaml@2 
PS1, Line 2:     summary: 'PlayDTMF testcase'
           :     description: |
           :         'asdf'
These should both be more descriptive :)


https://gerrit.asterisk.org/c/testsuite/+/13164/1/tests/manager/playdtmf/test-config.yaml@52 
PS1, Line 52:         ami-events:
            :             count: 1
            :             conditions:
            :                 match:
            :                     Event: 'UserEvent'
            :                     UserEvent: 'valid'
I would add another event here for 'invalid', and make sure it happens 0 times so that there's a failure case as well.



-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/13164
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 16
Gerrit-Change-Id: I50f29a7c86ad10ef0f94d1aebb6eca4d905b4ec4
Gerrit-Change-Number: 13164
Gerrit-PatchSet: 1
Gerrit-Owner: lvl <digium at lvlconsultancy.nl>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Comment-Date: Mon, 18 Nov 2019 21:46:17 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191118/aaac02a7/attachment-0001.html>