<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/testsuite/+/13164">View Change</a></p><p>5 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/testsuite/+/13164/1/tests/manager/playdtmf/sipp/invite.xml">File tests/manager/playdtmf/sipp/invite.xml:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/testsuite/+/13164/1/tests/manager/playdtmf/sipp/invite.xml@7">Patch Set #1, Line 7:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> INVITE sip:dialplan@[remote_ip]:[remote_port] SIP/2.0<br> Via: SIP/2.0/[transport] [local_ip]:[local_port];branch=[branch]<br> From: "alice" <sip:alice@[local_ip]:[local_port]>;tag=[call_number]<br> To: "bob" <sip:dialplan@[remote_ip]:[remote_port]><br> Call-ID: [call_id]<br> CSeq: [cseq] INVITE<br> Contact: sip:alice@[local_ip]:[local_port]<br> Max-Forwards: 70<br> Content-Type: application/sdp<br> Content-Length: [len]<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Use tab spacing</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/testsuite/+/13164/1/tests/manager/playdtmf/sipp/invite.xml@46">Patch Set #1, Line 46:</a> <code style="font-family:monospace,monospace"> Allow: INVITE, ACK, MESSAGE, BYE</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Tab spacing</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/testsuite/+/13164/1/tests/manager/playdtmf/sipp/invite.xml@64">Patch Set #1, Line 64:</a> <code style="font-family:monospace,monospace"> Allow: INVITE, ACK, MESSAGE, BYE</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Tab spacing</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/testsuite/+/13164/1/tests/manager/playdtmf/test-config.yaml">File tests/manager/playdtmf/test-config.yaml:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/testsuite/+/13164/1/tests/manager/playdtmf/test-config.yaml@2">Patch Set #1, Line 2:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> summary: 'PlayDTMF testcase'<br> description: |<br> 'asdf'<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">These should both be more descriptive :)</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/testsuite/+/13164/1/tests/manager/playdtmf/test-config.yaml@52">Patch Set #1, Line 52:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;"> ami-events:<br> count: 1<br> conditions:<br> match:<br> Event: 'UserEvent'<br> UserEvent: 'valid'<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I would add another event here for 'invalid', and make sure it happens 0 times so that there's a failure case as well.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/testsuite/+/13164">change 13164</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/testsuite/+/13164"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: testsuite </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I50f29a7c86ad10ef0f94d1aebb6eca4d905b4ec4 </div>
<div style="display:none"> Gerrit-Change-Number: 13164 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: lvl <digium@lvlconsultancy.nl> </div>
<div style="display:none"> Gerrit-Reviewer: Benjamin Keith Ford <bford@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 18 Nov 2019 21:46:17 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>