[Asterisk-code-review] bridge_softmix: clear hold when joining a softmix bridge (asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13202 )

Change subject: bridge_softmix: clear hold when joining a softmix bridge
......................................................................


Patch Set 2:

(1 comment)

> Patch Set 2: Code-Review-1
> 
> (1 comment)

https://gerrit.asterisk.org/c/asterisk/+/13202/2/bridges/bridge_softmix.c 
File bridges/bridge_softmix.c:

https://gerrit.asterisk.org/c/asterisk/+/13202/2/bridges/bridge_softmix.c@486 
PS2, Line 486: 		ast_indicate(bridge_channel->chan, AST_CONTROL_UNHOLD);
> If Bob placed Alice on hold then this is Bob's channel right?  So what actually happens to Bob and B […]
No, it's Alice. The way hold/unhold works in Asterisk is that it is the other side that gets put on hold. That is: If the phone of Bob hits the hold button then within the core and Asterisk it is Alice who is on hold. Bob does not appear on hold, and this wouldn't alter that.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13202
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I66ccd4efc80f5b4c3dd68186b379eb442916392b
Gerrit-Change-Number: 13202
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-CC: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Thu, 14 Nov 2019 15:55:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191114/c49600f9/attachment-0001.html>