[Asterisk-code-review] bridge_softmix: clear hold when joining a softmix bridge (asterisk[13])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13202 )

Change subject: bridge_softmix: clear hold when joining a softmix bridge
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/c/asterisk/+/13202/2/bridges/bridge_softmix.c 
File bridges/bridge_softmix.c:

https://gerrit.asterisk.org/c/asterisk/+/13202/2/bridges/bridge_softmix.c@486 
PS2, Line 486: 		ast_indicate(bridge_channel->chan, AST_CONTROL_UNHOLD);
If Bob placed Alice on hold then this is Bob's channel right?  So what actually happens to Bob and Bob's phone when we indicate UNHOLD?  His phone can't come off hold without him taking some physical action so does this mean the phone and channel are in inconsistent states?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13202
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I66ccd4efc80f5b4c3dd68186b379eb442916392b
Gerrit-Change-Number: 13202
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Thu, 14 Nov 2019 15:37:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191114/cb162159/attachment-0001.html>