[Asterisk-code-review] func_curl.c: Support custom http headers (asterisk[13])

[Sean Bright]

Sean Bright has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/13166 )

Change subject: func_curl.c: Support custom http headers
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

https://gerrit.asterisk.org/c/asterisk/+/13166/1/funcs/func_curl.c 
File funcs/func_curl.c:

https://gerrit.asterisk.org/c/asterisk/+/13166/1/funcs/func_curl.c@103 
PS1, Line 103: 						<para>Add HTTP header. Multiple calls adds multiple headers.
"adds" -> "add"


https://gerrit.asterisk.org/c/asterisk/+/13166/1/funcs/func_curl.c@104 
PS1, Line 104: 						Setting of any header will remove the default
             : 						"Content-Type application/x-www-form-urlencoded"
Why is this the case? If I set the 'X-Foo' header, it will remove the 'Content-Type' header?


https://gerrit.asterisk.org/c/asterisk/+/13166/1/funcs/func_curl.c@167 
PS1, Line 167: 			settings will override global settings. Only http headers are added instead of overriding</para>
"http" -> "HTTP"


https://gerrit.asterisk.org/c/asterisk/+/13166/1/funcs/func_curl.c@403 
PS1, Line 403: 		AST_LIST_LOCK(list);
This lock needs to be done outside of the 'if' statement due to the subsequent unlock being unguarded.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/13166
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I4dd68c3f4e25362ef941d73a3861f58348dcfbf9
Gerrit-Change-Number: 13166
Gerrit-PatchSet: 1
Gerrit-Owner: Martin Tomec <tomec.martin at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Thu, 14 Nov 2019 15:54:31 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20191114/fec8532e/attachment.html>