<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13166">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/c/asterisk/+/13166/1/funcs/func_curl.c">File funcs/func_curl.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/13166/1/funcs/func_curl.c@103">Patch Set #1, Line 103:</a> <code style="font-family:monospace,monospace">                                           <para>Add HTTP header. Multiple calls adds multiple headers.</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"adds" -> "add"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/13166/1/funcs/func_curl.c@104">Patch Set #1, Line 104:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">                                          Setting of any header will remove the default<br>                                         "Content-Type application/x-www-form-urlencoded"<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Why is this the case? If I set the 'X-Foo' header, it will remove the 'Content-Type' header?</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/13166/1/funcs/func_curl.c@167">Patch Set #1, Line 167:</a> <code style="font-family:monospace,monospace">                     settings will override global settings. Only http headers are added instead of overriding</para></code></p><p style="white-space: pre-wrap; word-wrap: break-word;">"http" -> "HTTP"</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/c/asterisk/+/13166/1/funcs/func_curl.c@403">Patch Set #1, Line 403:</a> <code style="font-family:monospace,monospace">          AST_LIST_LOCK(list);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">This lock needs to be done outside of the 'if' statement due to the subsequent unlock being unguarded.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/13166">change 13166</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/13166"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-Change-Id: I4dd68c3f4e25362ef941d73a3861f58348dcfbf9 </div>
<div style="display:none"> Gerrit-Change-Number: 13166 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Martin Tomec <tomec.martin@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 14 Nov 2019 15:54:31 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>