[Asterisk-code-review] chan_pjsip: Transmit REFER waits for the REFER result setting TRANSF... (...asterisk[master])

[Dan Cropp]

My apologies.

I did reply to several comments.  Basically I was looking for some feedback.

Perhaps the way I replied is not the correct way?

When I am logged in and look at the comments, I see Joshua’s comment.  I hit the reply button and typed in the reply.
For example, on line 1909 comment.  When I click this, I see Joshua’s comment from April 16, 7:53 AM.  Below that I see my comment from April 17 2:47 PM.

Is there a better way to ask questions on making the change?
Or should I just modify the code and submit for a new review to see if I’m going in the right direction?

Have a great day!

Dan

From: mattf <asteriskteam at digium.com>
Sent: Monday, May 13, 2019 9:37 AM
To: Dan Cropp <dan at amtelco.com>; asterisk-code-review at lists.digium.com
Cc: Joshua Colp <jcolp at digium.com>
Subject: chan_pjsip: Transmit REFER waits for the REFER result setting TRANSF... (...asterisk[master])


Dan, were you planning on responding to Josh's feedback?

View Change<https://gerrit.asterisk.org/c/asterisk/+/11216>

To view, visit change 11216<https://gerrit.asterisk.org/c/asterisk/+/11216>. To unsubscribe, or for help writing mail filters, visit settings<https://gerrit.asterisk.org/settings>.
Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: If6c27c757c66f71e8b75e3fe49da53ebe62395dc
Gerrit-Change-Number: 11216
Gerrit-PatchSet: 1
Gerrit-Owner: Dan Cropp <dan at amtelco.com<mailto:dan at amtelco.com>>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com<mailto:jcolp at digium.com>>
Gerrit-Reviewer: mattf <creslin at digium.com<mailto:creslin at digium.com>>
Gerrit-Comment-Date: Mon, 13 May 2019 14:36:42 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190513/82fc2614/attachment-0001.html>