<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="Generator" content="Microsoft Word 15 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Wingdings;
panose-1:5 0 0 0 0 0 0 0 0 0;}
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
p.msonormal0, li.msonormal0, div.msonormal0
{mso-style-name:msonormal;
mso-margin-top-alt:auto;
margin-right:0in;
mso-margin-bottom-alt:auto;
margin-left:0in;
font-size:11.0pt;
font-family:"Calibri",sans-serif;}
span.EmailStyle20
{mso-style-type:personal-reply;
font-family:"Calibri",sans-serif;
color:windowtext;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri",sans-serif;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
/* List Definitions */
@list l0
{mso-list-id:185795200;
mso-list-template-ids:190110086;}
@list l0:level1
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:.5in;
mso-level-number-position:left;
text-indent:-.25in;
mso-ansi-font-size:10.0pt;
font-family:Symbol;}
@list l0:level2
{mso-level-number-format:bullet;
mso-level-text:o;
mso-level-tab-stop:1.0in;
mso-level-number-position:left;
text-indent:-.25in;
mso-ansi-font-size:10.0pt;
font-family:"Courier New";
mso-bidi-font-family:"Times New Roman";}
@list l0:level3
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:1.5in;
mso-level-number-position:left;
text-indent:-.25in;
mso-ansi-font-size:10.0pt;
font-family:Wingdings;}
@list l0:level4
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:2.0in;
mso-level-number-position:left;
text-indent:-.25in;
mso-ansi-font-size:10.0pt;
font-family:Wingdings;}
@list l0:level5
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:2.5in;
mso-level-number-position:left;
text-indent:-.25in;
mso-ansi-font-size:10.0pt;
font-family:Wingdings;}
@list l0:level6
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:3.0in;
mso-level-number-position:left;
text-indent:-.25in;
mso-ansi-font-size:10.0pt;
font-family:Wingdings;}
@list l0:level7
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:3.5in;
mso-level-number-position:left;
text-indent:-.25in;
mso-ansi-font-size:10.0pt;
font-family:Wingdings;}
@list l0:level8
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:4.0in;
mso-level-number-position:left;
text-indent:-.25in;
mso-ansi-font-size:10.0pt;
font-family:Wingdings;}
@list l0:level9
{mso-level-number-format:bullet;
mso-level-text:;
mso-level-tab-stop:4.5in;
mso-level-number-position:left;
text-indent:-.25in;
mso-ansi-font-size:10.0pt;
font-family:Wingdings;}
ol
{margin-bottom:0in;}
ul
{margin-bottom:0in;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal">My apologies.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">I did reply to several comments. Basically I was looking for some feedback.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Perhaps the way I replied is not the correct way?<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">When I am logged in and look at the comments, I see Joshua’s comment. I hit the reply button and typed in the reply.<o:p></o:p></p>
<p class="MsoNormal">For example, on line 1909 comment. When I click this, I see Joshua’s comment from April 16, 7:53 AM. Below that I see my comment from April 17 2:47 PM.<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Is there a better way to ask questions on making the change?<o:p></o:p></p>
<p class="MsoNormal">Or should I just modify the code and submit for a new review to see if I’m going in the right direction?<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Have a great day!<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal">Dan<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal"><b>From:</b> mattf <asteriskteam@digium.com> <br>
<b>Sent:</b> Monday, May 13, 2019 9:37 AM<br>
<b>To:</b> Dan Cropp <dan@amtelco.com>; asterisk-code-review@lists.digium.com<br>
<b>Cc:</b> Joshua Colp <jcolp@digium.com><br>
<b>Subject:</b> chan_pjsip: Transmit REFER waits for the REFER result setting TRANSF... (...asterisk[master])<o:p></o:p></p>
<p class="MsoNormal"><o:p> </o:p></p>
<p>Dan, were you planning on responding to Josh's feedback?<o:p></o:p></p>
<p><a href="https://gerrit.asterisk.org/c/asterisk/+/11216">View Change</a><o:p></o:p></p>
<p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/11216">change 11216</a>. To unsubscribe, or for help writing mail filters, visit
<a href="https://gerrit.asterisk.org/settings">settings</a>.<o:p></o:p></p>
<div>
<p class="MsoNormal">Gerrit-Project: asterisk <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Gerrit-Branch: master <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Gerrit-Change-Id: If6c27c757c66f71e8b75e3fe49da53ebe62395dc <o:p>
</o:p></p>
</div>
<div>
<p class="MsoNormal">Gerrit-Change-Number: 11216 <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Gerrit-PatchSet: 1 <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Gerrit-Owner: Dan Cropp <<a href="mailto:dan@amtelco.com">dan@amtelco.com</a>>
<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Gerrit-Reviewer: Friendly Automation <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Gerrit-Reviewer: Joshua Colp <<a href="mailto:jcolp@digium.com">jcolp@digium.com</a>>
<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Gerrit-Reviewer: mattf <<a href="mailto:creslin@digium.com">creslin@digium.com</a>>
<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Gerrit-Comment-Date: Mon, 13 May 2019 14:36:42 +0000 <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Gerrit-HasComments: No <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Gerrit-Has-Labels: No <o:p></o:p></p>
</div>
<div>
<p class="MsoNormal">Gerrit-MessageType: comment <o:p></o:p></p>
</div>
</div>
</body>
</html>