[Asterisk-code-review] app_confbridge: Add "all" variants of REMB behavior. (...asterisk[16])

Joshua Colp asteriskteam at digium.com
Thu May 2 08:28:56 CDT 2019


Hello Benjamin Keith Ford, Kevin Harwell, Friendly Automation, George Joseph, Sean Bright, 

I'd like you to reexamine a change. Please visit

    https://gerrit.asterisk.org/c/asterisk/+/11321

to look at the new patch set (#3).

Change subject: app_confbridge: Add "all" variants of REMB behavior.
......................................................................

app_confbridge: Add "all" variants of REMB behavior.

When producing a combined REMB value the normal behavior
is to have a REMB value which is unique for each sender
based on all of their receivers. This can result in one
sender having low bitrate while all the rest are high.

This change adds "all" variants which produces a bridge
level REMB value instead. All REMB reports are combined
together into a single REMB value that is the same for
each sender.

ASTERISK-28401

Change-Id: I883e6cc26003b497c8180b346111c79a131ba88c
---
M apps/app_confbridge.c
M apps/confbridge/conf_config_parser.c
M apps/confbridge/include/confbridge.h
M bridges/bridge_softmix.c
M bridges/bridge_softmix/include/bridge_softmix_internal.h
M configs/samples/confbridge.conf.sample
A doc/CHANGES-staging/app_confbridge_remb_behavior_all.txt
M include/asterisk/bridge.h
8 files changed, 122 insertions(+), 9 deletions(-)


  git pull ssh://gerrit.asterisk.org:29418/asterisk refs/changes/21/11321/3
-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11321
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I883e6cc26003b497c8180b346111c79a131ba88c
Gerrit-Change-Number: 11321
Gerrit-PatchSet: 3
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-MessageType: newpatchset
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190502/613f3d9c/attachment-0001.html>


More information about the asterisk-code-review mailing list