[Asterisk-code-review] app_confbridge: Add "all" variants of REMB behavior. (...asterisk[16])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11321 )

Change subject: app_confbridge: Add "all" variants of REMB behavior.
......................................................................


Patch Set 2:

(2 comments)

Minor nit.  not -1ing

https://gerrit.asterisk.org/#/c/11321/2/bridges/bridge_softmix.c 
File bridges/bridge_softmix.c:

https://gerrit.asterisk.org/#/c/11321/2/bridges/bridge_softmix.c@1360 
PS2, Line 1360: 		/* These will never actually get hit */
It's obvious if you keep reading down but maybe say "Handled by remb_collect_report, below."


https://gerrit.asterisk.org/#/c/11321/2/bridges/bridge_softmix.c@1424 
PS2, Line 1424: 			/* These will never actually get hit */
Same as above except the reverse.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11321
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I883e6cc26003b497c8180b346111c79a131ba88c
Gerrit-Change-Number: 11321
Gerrit-PatchSet: 2
Gerrit-Owner: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Thu, 02 May 2019 13:26:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190502/3cadb80c/attachment.html>