[Asterisk-code-review] main/pbx.c: Fixed to call the ast_softhangup() (...asterisk[master])

[sungtae kim]

sungtae kim has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11149 )

Change subject: main/pbx.c: Fixed to call the ast_softhangup()
......................................................................


Patch Set 6:

(1 comment)

> Patch Set 4: Code-Review-1
> 
> (1 comment)

Hi Joshua,

Thank you for your kind reviewing. I've submitted another patch for that.

Btw, is that ok to creating ticket for function refactoring?

https://gerrit.asterisk.org/#/c/11149/4/main/pbx.c 
File main/pbx.c:

https://gerrit.asterisk.org/#/c/11149/4/main/pbx.c@4579 
PS4, Line 4579: 
> The removal of ast_hangup will cause problems, as the channel won't be hung up. […]
Because Asterisk does the hangup() twice and crashed. I thought that part makes the problem.

But I was wrong, I submitted another patch for that fixes.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11149
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I6652359e42bb9fe3f2c44c03df4365c183baf73d
Gerrit-Change-Number: 11149
Gerrit-PatchSet: 6
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Wed, 27 Mar 2019 01:02:29 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190326/3b6f640a/attachment-0001.html>