<blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Patch Set 4: Code-Review-1</p><p style="white-space: pre-wrap; word-wrap: break-word;">(1 comment)</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">Hi Joshua,</p><p style="white-space: pre-wrap; word-wrap: break-word;">Thank you for your kind reviewing. I've submitted another patch for that.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Btw, is that ok to creating ticket for function refactoring?</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/11149">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/11149/4/main/pbx.c">File main/pbx.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/11149/4/main/pbx.c@4579">Patch Set #4, Line 4579:</a> <code style="font-family:monospace,monospace"></code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">The removal of ast_hangup will cause problems, as the channel won't be hung up. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Because Asterisk does the hangup() twice and crashed. I thought that part makes the problem.</p><p style="white-space: pre-wrap; word-wrap: break-word;">But I was wrong, I submitted another patch for that fixes.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/11149">change 11149</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/11149"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I6652359e42bb9fe3f2c44c03df4365c183baf73d </div>
<div style="display:none"> Gerrit-Change-Number: 11149 </div>
<div style="display:none"> Gerrit-PatchSet: 6 </div>
<div style="display:none"> Gerrit-Owner: sungtae kim <pchero21@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: sungtae kim <pchero21@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 27 Mar 2019 01:02:29 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>