[Asterisk-code-review] main/json.c: Added app_name, app_data to channel type (...asterisk[master])

[sungtae kim]

sungtae kim has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11164 )

Change subject: main/json.c: Added app_name, app_data to channel type
......................................................................


Patch Set 5:

> Patch Set 5: Code-Review-1
> 
> What George was saying is that ast_json_dialplan_cep() cannot be changed OR removed because of ABI. if there is a module out there that links ast_json_dialplan_cep(), it will fail to load once your change lands.
> 
> Just adding a #define won't cut it because that is a compile-time thing, not a runtime one.
> 
> You should create a new function called ast_json_dialplan_cep_app(), leaving ast_json_dialplan_cep() alone.
> 
> You can then change the implementation of ast_json_dialplan_cep() to call your new ast_json_dialplan_cep_app() internally which won't break anything.

Hi Sean,

Thank you for your kind reviewing. :)

Ah...! You're right! I've fixed it. :)


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11164
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: Ia48972b3850e5099deab0faeaaf51223a1f2f38c
Gerrit-Change-Number: 11164
Gerrit-PatchSet: 5
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Tue, 26 Mar 2019 20:08:21 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190326/d0236c9f/attachment.html>