<blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><p style="white-space: pre-wrap; word-wrap: break-word;">Patch Set 5: Code-Review-1</p><p style="white-space: pre-wrap; word-wrap: break-word;">What George was saying is that ast_json_dialplan_cep() cannot be changed OR removed because of ABI. if there is a module out there that links ast_json_dialplan_cep(), it will fail to load once your change lands.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Just adding a #define won't cut it because that is a compile-time thing, not a runtime one.</p><p style="white-space: pre-wrap; word-wrap: break-word;">You should create a new function called ast_json_dialplan_cep_app(), leaving ast_json_dialplan_cep() alone.</p><p style="white-space: pre-wrap; word-wrap: break-word;">You can then change the implementation of ast_json_dialplan_cep() to call your new ast_json_dialplan_cep_app() internally which won't break anything.</p></blockquote><p style="white-space: pre-wrap; word-wrap: break-word;">Hi Sean,</p><p style="white-space: pre-wrap; word-wrap: break-word;">Thank you for your kind reviewing. :)</p><p style="white-space: pre-wrap; word-wrap: break-word;">Ah...! You're right! I've fixed it. :)</p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/11164">View Change</a></p><ul style="list-style: none; padding: 0;"></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/11164">change 11164</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/11164"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Ia48972b3850e5099deab0faeaaf51223a1f2f38c </div>
<div style="display:none"> Gerrit-Change-Number: 11164 </div>
<div style="display:none"> Gerrit-PatchSet: 5 </div>
<div style="display:none"> Gerrit-Owner: sungtae kim <pchero21@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: sungtae kim <pchero21@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 26 Mar 2019 20:08:21 +0000 </div>
<div style="display:none"> Gerrit-HasComments: No </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>