[Asterisk-code-review] stasis: Improve topic/subscription names and statistics. (...asterisk[13])

[Richard Mudgett]

Richard Mudgett has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11127 )

Change subject: stasis: Improve topic/subscription names and statistics.
......................................................................


Patch Set 1: Code-Review-1

(4 comments)

https://gerrit.asterisk.org/#/c/11127/1/main/stasis.c 
File main/stasis.c:

https://gerrit.asterisk.org/#/c/11127/1/main/stasis.c@2144 
PS1, Line 2144: OBJ_POINTER - if set, 'obj_right', is an object.
              :  *   OBJ_KEY - if set, 'obj_right', is a search key item that is not an object.
              :  *   OBJ_PARTIAL_KEY
The OBJ_POINTER, OBJ_KEY, OBJ_PARTIAL_KEY are deprecated.  Please use the OBJ_SEARCH_OBJECT, OBJ_SEARCH_KEY, and OBJ_SEARCH_PARTIAL_KEY names.


https://gerrit.asterisk.org/#/c/11127/1/main/stasis.c@2159 
PS1, Line 2159: switch (flags & (OBJ_POINTER | OBJ_KEY | OBJ_PARTIAL_KEY)) {
              : 	default:
              : 	case OBJ_POINTER:
              : 		right_key = statistics_right->uniqueid;
              : 	/* Fall through */
              : 	case OBJ_KEY:
              : 		cmp = strcmp(statistics_left->uniqueid, right_key);
              : 		break;
              : 	case OBJ_PARTIAL_KEY
The OBJ_POINTER, OBJ_KEY, OBJ_PARTIAL_KEY are deprecated.  Please use the OBJ_SEARCH_OBJECT, OBJ_SEARCH_KEY, and OBJ_SEARCH_PARTIAL_KEY names.

Also there is an OBJ_SEARCH_MASK defined for the mask manually built here.


https://gerrit.asterisk.org/#/c/11127/1/main/stasis.c@2345 
PS1, Line 2345: OBJ_POINTER - if set, 'obj_right', is an object.
              :  *   OBJ_KEY - if set, 'obj_right', is a search key item that is not an object.
              :  *   OBJ_PARTIAL_KEY
The OBJ_POINTER, OBJ_KEY, OBJ_PARTIAL_KEY are deprecated.  Please use the OBJ_SEARCH_OBJECT, OBJ_SEARCH_KEY, and OBJ_SEARCH_PARTIAL_KEY names.


https://gerrit.asterisk.org/#/c/11127/1/main/stasis.c@2360 
PS1, Line 2360: switch (flags & (OBJ_POINTER | OBJ_KEY | OBJ_PARTIAL_KEY)) {
              : 	default:
              : 	case OBJ_POINTER:
              : 		right_key = topic_right->name;
              : 		/* Fall through */
              : 	case OBJ_KEY:
              : 		cmp = strcmp(topic_left->name, right_key);
              : 		break;
              : 	case OBJ_PARTIAL_KEY
The OBJ_POINTER, OBJ_KEY, OBJ_PARTIAL_KEY are deprecated.  Please use the OBJ_SEARCH_OBJECT, OBJ_SEARCH_KEY, and OBJ_SEARCH_PARTIAL_KEY names.

Also there is an OBJ_SEARCH_MASK defined for the mask manually built here.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11127
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I484e971a38c3640f2bd156282e532eed84bf220d
Gerrit-Change-Number: 11127
Gerrit-PatchSet: 1
Gerrit-Owner: Joshua C. Colp <jcolp at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Comment-Date: Mon, 11 Mar 2019 13:08:57 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190311/8d679f03/attachment.html>