<p>Patch set 1:<span style="border-radius: 3px; display: inline-block; margin: 0 2px; padding: 4px;background-color: #ffd4d4; color: #000000;">Code-Review -1</span></p><p><a href="https://gerrit.asterisk.org/c/asterisk/+/11127">View Change</a></p><p>4 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/11127/1/main/stasis.c">File main/stasis.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/11127/1/main/stasis.c@2144">Patch Set #1, Line 2144:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">OBJ_POINTER - if set, 'obj_right', is an object.<br> * OBJ_KEY - if set, 'obj_right', is a search key item that is not an object.<br> * OBJ_PARTIAL_KEY<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">The OBJ_POINTER, OBJ_KEY, OBJ_PARTIAL_KEY are deprecated. Please use the OBJ_SEARCH_OBJECT, OBJ_SEARCH_KEY, and OBJ_SEARCH_PARTIAL_KEY names.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/11127/1/main/stasis.c@2159">Patch Set #1, Line 2159:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">switch (flags & (OBJ_POINTER | OBJ_KEY | OBJ_PARTIAL_KEY)) {<br> default:<br> case OBJ_POINTER:<br> right_key = statistics_right->uniqueid;<br> /* Fall through */<br> case OBJ_KEY:<br> cmp = strcmp(statistics_left->uniqueid, right_key);<br> break;<br> case OBJ_PARTIAL_KEY<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">The OBJ_POINTER, OBJ_KEY, OBJ_PARTIAL_KEY are deprecated. Please use the OBJ_SEARCH_OBJECT, OBJ_SEARCH_KEY, and OBJ_SEARCH_PARTIAL_KEY names.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Also there is an OBJ_SEARCH_MASK defined for the mask manually built here.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/11127/1/main/stasis.c@2345">Patch Set #1, Line 2345:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">OBJ_POINTER - if set, 'obj_right', is an object.<br> * OBJ_KEY - if set, 'obj_right', is a search key item that is not an object.<br> * OBJ_PARTIAL_KEY<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">The OBJ_POINTER, OBJ_KEY, OBJ_PARTIAL_KEY are deprecated. Please use the OBJ_SEARCH_OBJECT, OBJ_SEARCH_KEY, and OBJ_SEARCH_PARTIAL_KEY names.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/11127/1/main/stasis.c@2360">Patch Set #1, Line 2360:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">switch (flags & (OBJ_POINTER | OBJ_KEY | OBJ_PARTIAL_KEY)) {<br> default:<br> case OBJ_POINTER:<br> right_key = topic_right->name;<br> /* Fall through */<br> case OBJ_KEY:<br> cmp = strcmp(topic_left->name, right_key);<br> break;<br> case OBJ_PARTIAL_KEY<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">The OBJ_POINTER, OBJ_KEY, OBJ_PARTIAL_KEY are deprecated. Please use the OBJ_SEARCH_OBJECT, OBJ_SEARCH_KEY, and OBJ_SEARCH_PARTIAL_KEY names.</p><p style="white-space: pre-wrap; word-wrap: break-word;">Also there is an OBJ_SEARCH_MASK defined for the mask manually built here.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/11127">change 11127</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/11127"/><meta itemprop="name" content="View Change"/></div></div>
<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-Change-Id: I484e971a38c3640f2bd156282e532eed84bf220d </div>
<div style="display:none"> Gerrit-Change-Number: 11127 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Joshua C. Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Mon, 11 Mar 2019 13:08:57 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: Yes </div>
<div style="display:none"> Gerrit-MessageType: comment </div>