[Asterisk-code-review] res/res_rtp_asterisk.c: Fixing possible divide by zero (...asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11085 )

Change subject: res/res_rtp_asterisk.c: Fixing possible divide by zero
......................................................................


Patch Set 3: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/11085/3/res/res_rtp_asterisk.c 
File res/res_rtp_asterisk.c:

https://gerrit.asterisk.org/#/c/11085/3/res/res_rtp_asterisk.c@3077 
PS3, Line 3077: 	if (sample_count == 0) {
Add a comment specifying why this was done. Logic like this can make future people go "I don't understand why this was done" when looking.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11085
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: If7e0629abaceddd2166eb012456c53033ea26249
Gerrit-Change-Number: 11085
Gerrit-PatchSet: 3
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Thu, 07 Mar 2019 11:33:05 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190307/0bc39ea6/attachment.html>