[Asterisk-code-review] res/res_rtp_asterisk.c: Fixing possible divide by zero (...asterisk[master])

sungtae kim asteriskteam at digium.com
Wed Mar 6 15:36:43 CST 2019


sungtae kim has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11085 )

Change subject: res/res_rtp_asterisk.c: Fixing possible divide by zero
......................................................................


Patch Set 2:

> Patch Set 2: Code-Review-1
> 
> This is not what we discussed yesterday.
> 
> Don't change the argument types to these two functions. Leave them as ints.
> 
> Add code to these two functions (after the sample_count++) to check if sample_count is 0 and if it is, change it to 1.

Oooops, sorry. I was forgot the context.. -_-;;; 

Fixed it. :)


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11085
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: If7e0629abaceddd2166eb012456c53033ea26249
Gerrit-Change-Number: 11085
Gerrit-PatchSet: 2
Gerrit-Owner: sungtae kim <pchero21 at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: sungtae kim <pchero21 at gmail.com>
Gerrit-Comment-Date: Wed, 06 Mar 2019 21:36:43 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190306/8a88593e/attachment.html>


More information about the asterisk-code-review mailing list