[Asterisk-code-review] stasis_state: Add new stasis_state module (...asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11462 )

Change subject: stasis_state: Add new stasis_state module
......................................................................


Patch Set 1:

(3 comments)

https://gerrit.asterisk.org/#/c/11462/1/include/asterisk/stasis_state.h 
File include/asterisk/stasis_state.h:

https://gerrit.asterisk.org/#/c/11462/1/include/asterisk/stasis_state.h@425 
PS1, Line 425: /*! \brief Managed stasis state event interface */
> I don't feel that it is as it's part of, and directly related to the stasis state framework. […]
Yeah, I'm okay if it stays here.


https://gerrit.asterisk.org/#/c/11462/1/main/stasis_state.c 
File main/stasis_state.c:

https://gerrit.asterisk.org/#/c/11462/1/main/stasis_state.c@506 
PS1, Line 506: 	ao2_ref(sub, -1);
> These are here as a convenience to the caller since in most every case of unsubscribing you'll want  […]
This is counter to the way things usually work elsewhere, if you want to keep it I'd say the API call should make it clear. stasis_state_unsubscribe_and_unref for example.


https://gerrit.asterisk.org/#/c/11462/1/main/stasis_state.c@746 
PS1, Line 746: 	message_data = ao2_bump(stasis_message_data(state->msg));
> I debated which to pass. […]
I think it's better to be safe than sorry and provide the entire message.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11462
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I7a4a06685a96e511da9f5bd23f9601642d7bd8e5
Gerrit-Change-Number: 11462
Gerrit-PatchSet: 1
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Tue, 25 Jun 2019 12:49:15 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Comment-In-Reply-To: Joshua Colp <jcolp at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190625/6ac8d5d9/attachment-0001.html>