<p><a href="https://gerrit.asterisk.org/c/asterisk/+/11462">View Change</a></p><p>3 comments:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/11462/1/include/asterisk/stasis_state.h">File include/asterisk/stasis_state.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/11462/1/include/asterisk/stasis_state.h@425">Patch Set #1, Line 425:</a> <code style="font-family:monospace,monospace">/*! \brief Managed stasis state event interface */</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">I don't feel that it is as it's part of, and directly related to the stasis state framework. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Yeah, I'm okay if it stays here.</p></li></ul></li><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/11462/1/main/stasis_state.c">File main/stasis_state.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/11462/1/main/stasis_state.c@506">Patch Set #1, Line 506:</a> <code style="font-family:monospace,monospace">    ao2_ref(sub, -1);</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">These are here as a convenience to the caller since in most every case of unsubscribing you'll want  […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">This is counter to the way things usually work elsewhere, if you want to keep it I'd say the API call should make it clear. stasis_state_unsubscribe_and_unref for example.</p></li><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/11462/1/main/stasis_state.c@746">Patch Set #1, Line 746:</a> <code style="font-family:monospace,monospace">        message_data = ao2_bump(stasis_message_data(state->msg));</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">I debated which to pass. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">I think it's better to be safe than sorry and provide the entire message.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/11462">change 11462</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/11462"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: I7a4a06685a96e511da9f5bd23f9601642d7bd8e5 </div>
<div style="display:none"> Gerrit-Change-Number: 11462 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Tue, 25 Jun 2019 12:49:15 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Comment-In-Reply-To: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>