[Asterisk-code-review] res_mwi_external: Update to use new MWI state publishing API (...asterisk[master])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11465 )

Change subject: res_mwi_external: Update to use new MWI state publishing API
......................................................................


Patch Set 2:

(1 comment)

https://gerrit.asterisk.org/#/c/11465/2/res/res_mwi_external.c 
File res/res_mwi_external.c:

https://gerrit.asterisk.org/#/c/11465/2/res/res_mwi_external.c@128 
PS2, Line 128: static void *mwi_sorcery_object_alloc(const char *id)
> I believe this currently causes a leak and may not work as expected. […]
I don't think I quite follow. The publisher gets created here, and then cleaned up/destroyed when "mwi_observe_delete" is called. Wouldn't that balance things since there should be a delete for every create?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11465
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I07d41f1a0f0a0bae2e3621adf36057fa416a9bc9
Gerrit-Change-Number: 11465
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Mon, 24 Jun 2019 22:49:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190624/4229aff4/attachment.html>