[Asterisk-code-review] res_mwi_external: Update to use new MWI state publishing API (...asterisk[master])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11465 )

Change subject: res_mwi_external: Update to use new MWI state publishing API
......................................................................


Patch Set 2: Code-Review-1

(1 comment)

https://gerrit.asterisk.org/#/c/11465/2/res/res_mwi_external.c 
File res/res_mwi_external.c:

https://gerrit.asterisk.org/#/c/11465/2/res/res_mwi_external.c@128 
PS2, Line 128: static void *mwi_sorcery_object_alloc(const char *id)
I believe this currently causes a leak and may not work as expected. This module persists information in astdb and does not cache any data structures. As a result this can be pulled/recreated over and over - causing a leak to occur as the object will get destroyed afterwards. I think this will have to use the mechanism that does not require a publisher object and on delete it can then call the remove.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11465
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: master
Gerrit-Change-Id: I07d41f1a0f0a0bae2e3621adf36057fa416a9bc9
Gerrit-Change-Number: 11465
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Sun, 23 Jun 2019 17:33:41 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190623/520270a3/attachment-0001.html>