[Asterisk-code-review] res_fax: gateway sends T.38 request to both endpoints if V.21 detected (...asterisk[16])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11422 )

Change subject: res_fax: gateway sends T.38 request to both endpoints if V.21 detected
......................................................................


Patch Set 4:

(1 comment)

https://gerrit.asterisk.org/#/c/11422/4/res/res_fax.c 
File res/res_fax.c:

https://gerrit.asterisk.org/#/c/11422/4/res/res_fax.c@3050 
PS4, Line 3050: 			if (state_other == T38_STATE_UNKNOWN) {
> This patch is about to send T.38 request to both channels/endpoints. […]
That's what I am not understanding, so need clarification. To me scenario 3 makes it sound like it should not ever be sending a T.38 request to the calling endpoint?

As I said I may just be confused here (not familiar with the fax gateway). 2 channels/endpoints are involved right? The calling and the called? According to the wiki only the called gets sent a T.38 request. With this patch it now sends to both (the called and calling)? Or is there another channel involved I'm missing?



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11422
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-Change-Id: I73bb24799bfe1a48adae9c034a2edbae54cc2a39
Gerrit-Change-Number: 11422
Gerrit-PatchSet: 4
Gerrit-Owner: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Wed, 19 Jun 2019 17:04:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kevin Harwell <kharwell at digium.com>
Comment-In-Reply-To: Alexei Gradinari <alex2grad at gmail.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190619/7cff6bb4/attachment.html>