<p><a href="https://gerrit.asterisk.org/c/asterisk/+/11422">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/11422/4/res/res_fax.c">File res/res_fax.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/11422/4/res/res_fax.c@3050">Patch Set #4, Line 3050:</a> <code style="font-family:monospace,monospace">                  if (state_other == T38_STATE_UNKNOWN) {</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">This patch is about to send T.38 request to both channels/endpoints. […]</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">That's what I am not understanding, so need clarification. To me scenario 3 makes it sound like it should not ever be sending a T.38 request to the calling endpoint?</p><p style="white-space: pre-wrap; word-wrap: break-word;">As I said I may just be confused here (not familiar with the fax gateway). 2 channels/endpoints are involved right? The calling and the called? According to the wiki only the called gets sent a T.38 request. With this patch it now sends to both (the called and calling)? Or is there another channel involved I'm missing?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/asterisk/+/11422">change 11422</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/asterisk/+/11422"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-Change-Id: I73bb24799bfe1a48adae9c034a2edbae54cc2a39 </div>
<div style="display:none"> Gerrit-Change-Number: 11422 </div>
<div style="display:none"> Gerrit-PatchSet: 4 </div>
<div style="display:none"> Gerrit-Owner: Alexei Gradinari <alex2grad@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Alexei Gradinari <alex2grad@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Reviewer: George Joseph <gjoseph@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Joshua Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Wed, 19 Jun 2019 17:04:06 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Comment-In-Reply-To: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Comment-In-Reply-To: Alexei Gradinari <alex2grad@gmail.com> </div>
<div style="display:none"> Gerrit-MessageType: comment </div>