[Asterisk-code-review] mwi_subscribe_replaces_unsolicited: (...asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11628 )

Change subject: mwi_subscribe_replaces_unsolicited:
......................................................................


Patch Set 1:

> Patch Set 1:
> 
> (1 comment)
> 
> > (2 comments)
>  > 
>  > The create_mwi_subscriptions function removes all unsolicited MWI
>  > subscriptions and then recreates them. I think this would cause
>  > unsolicited to start again when a reload occurs.
> 
> I don't think so. Next time an unsolicited gets created, function endpoint_receives_unsolicited_mwi_for_mailbox() will verify with pjsip.conf and will set mwi_sub->is_subscribe_replaces_unsolicited to back to true.

There would be no MWI subscription in the unsolicited_mwi container, so the function would immediately return 0 causing a new unsolicited MWI subscription to be created, and mwi_sub->is_subscribe_replaces_unsolicited would be set to 0.


-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11628
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I8f77c33b9b4d374d510aa5ecd4f700a77107d8d4
Gerrit-Change-Number: 11628
Gerrit-PatchSet: 1
Gerrit-Owner: Christian Savinovich <csavinovich at digium.com>
Gerrit-Reviewer: Christian Savinovich <csavinovich at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Fri, 26 Jul 2019 21:18:59 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190726/3f457ded/attachment.html>