[Asterisk-code-review] mwi_subscribe_replaces_unsolicited: (...asterisk[13])

[Christian Savinovich]

Christian Savinovich has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11628 )

Change subject: mwi_subscribe_replaces_unsolicited:
......................................................................


Patch Set 1:

(1 comment)

> (2 comments)
 > 
 > The create_mwi_subscriptions function removes all unsolicited MWI
 > subscriptions and then recreates them. I think this would cause
 > unsolicited to start again when a reload occurs.

I don't think so. Next time an unsolicited gets created, function endpoint_receives_unsolicited_mwi_for_mailbox() will verify with pjsip.conf and will set mwi_sub->is_subscribe_replaces_unsolicited to back to true.

https://gerrit.asterisk.org/#/c/11628/1/res/res_pjsip_mwi.c 
File res/res_pjsip_mwi.c:

https://gerrit.asterisk.org/#/c/11628/1/res/res_pjsip_mwi.c@684 
PS1, Line 684: 		struct ast_sip_endpoint *endpoint = ast_sip_subscription_get_endpoint(sub->sip_sub);
> Does this check actually need to be done on the endpoint? If the above field is set, then the endpoi […]
You are right.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11628
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I8f77c33b9b4d374d510aa5ecd4f700a77107d8d4
Gerrit-Change-Number: 11628
Gerrit-PatchSet: 1
Gerrit-Owner: Christian Savinovich <csavinovich at digium.com>
Gerrit-Reviewer: Christian Savinovich <csavinovich at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Fri, 26 Jul 2019 21:12:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Joshua Colp <jcolp at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190726/bdf658ec/attachment.html>