[Asterisk-code-review] mwi_subscribe_replaces_unsolicited: (...asterisk[13])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11628 )

Change subject: mwi_subscribe_replaces_unsolicited:
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/11628/1/res/res_pjsip_mwi.c 
File res/res_pjsip_mwi.c:

https://gerrit.asterisk.org/#/c/11628/1/res/res_pjsip_mwi.c@787 
PS1, Line 787: 				ao2_cleanup(mwi_stasis);
> I think this needs to be outside the "if invoked" otherwise mwi_stasis will be leaked.
Or I think you can combine your check with the pre-existing if? For instance:

if (endpoint->subscription.mwi.subscribe_replaces_unsolicited && !invokedByValidate)

I think that would do the same thing, remove one level of indention, and no longer leak the mwi_stasis object.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11628
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I8f77c33b9b4d374d510aa5ecd4f700a77107d8d4
Gerrit-Change-Number: 11628
Gerrit-PatchSet: 1
Gerrit-Owner: Christian Savinovich <csavinovich at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Fri, 26 Jul 2019 14:40:35 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190726/6bafcb94/attachment.html>