[Asterisk-code-review] mwi_subscribe_replaces_unsolicited: (...asterisk[13])

[Joshua Colp]

Joshua Colp has posted comments on this change. ( https://gerrit.asterisk.org/c/asterisk/+/11628 )

Change subject: mwi_subscribe_replaces_unsolicited:
......................................................................


Patch Set 1: Code-Review-1

(2 comments)

The create_mwi_subscriptions function removes all unsolicited MWI subscriptions and then recreates them. I think this would cause unsolicited to start again when a reload occurs.

https://gerrit.asterisk.org/#/c/11628/1/res/res_pjsip_mwi.c 
File res/res_pjsip_mwi.c:

https://gerrit.asterisk.org/#/c/11628/1/res/res_pjsip_mwi.c@683 
PS1, Line 683: 	if (sub->is_subscribe_replaces_unsolicited) {
> Is this actually needed?  Wouldn't "is_solicited" be set on this subscription?
The subscription in the container that remains is the unsolicited one, not the solicited one, so that field would not be set.


https://gerrit.asterisk.org/#/c/11628/1/res/res_pjsip_mwi.c@684 
PS1, Line 684: 		struct ast_sip_endpoint *endpoint = ast_sip_subscription_get_endpoint(sub->sip_sub);
Does this check actually need to be done on the endpoint? If the above field is set, then the endpoint would have had subscribe_replaces_unsolicited set in the first place.



-- 
To view, visit https://gerrit.asterisk.org/c/asterisk/+/11628
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-Change-Id: I8f77c33b9b4d374d510aa5ecd4f700a77107d8d4
Gerrit-Change-Number: 11628
Gerrit-PatchSet: 1
Gerrit-Owner: Christian Savinovich <csavinovich at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Joshua Colp <jcolp at digium.com>
Gerrit-Comment-Date: Fri, 26 Jul 2019 13:27:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190726/972390ce/attachment.html>