[Asterisk-code-review] pjsip/basic_calls: Add a few more nominal and off nominal basic calls... (...testsuite[16])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/c/testsuite/+/11567 )

Change subject: pjsip/basic_calls: Add a few more nominal and off nominal basic calls tests
......................................................................


Patch Set 4:

(2 comments)

https://gerrit.asterisk.org/#/c/11567/4/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_anonymous/test-config.yaml 
File tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_anonymous/test-config.yaml:

https://gerrit.asterisk.org/#/c/11567/4/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_anonymous/test-config.yaml@1 
PS4, Line 1: testinfo:
> Do we need a test to ensure that if the "anonymous" identify module isn't loaded an anonymous call w […]
I wondered the same thing. Opted at the time to not add one as I figured we already have tests checking authentication for endpoints. Which I then figured any test that does that (like the wrong_password one) is pretty much equivalent to an anonymous call.

I could try to add one in specifically for this if you think it'd be worthwhile?


https://gerrit.asterisk.org/#/c/11567/4/tests/channels/pjsip/basic_calls/outgoing/off-nominal/bob_is_busy_at/test-config.yaml 
File tests/channels/pjsip/basic_calls/outgoing/off-nominal/bob_is_busy_at/test-config.yaml:

https://gerrit.asterisk.org/#/c/11567/4/tests/channels/pjsip/basic_calls/outgoing/off-nominal/bob_is_busy_at/test-config.yaml@1 
PS4, Line 1: testinfo:
> I must be missing something.  I don't see the second originate. […]
The first originate is initiated by the "Originator" module. It just uses all the defaults, so there was no need for a config section. The second one is done through the AMI action below and it triggered off a received event.

Regarding your question...

I initially went that route, but the second call did not fail. Either there were timing problems (hard to sync the two calling scenarios), and also as far as I can tell Asterisk still dials if the endpoint is busy. It's up to the user to configure the dialplan to dial or not dial based on some state I believe.

Doing it this way allowed for checking the endpoint state, and simplified the test.



-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/11567
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 16
Gerrit-Change-Id: Iae9854ea496d7241c1a4f9cd551be2ca1fb01078
Gerrit-Change-Number: 11567
Gerrit-PatchSet: 4
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Comment-Date: Fri, 19 Jul 2019 18:18:33 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: George Joseph <gjoseph at digium.com>
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190719/9ceb87f0/attachment-0001.html>