[Asterisk-code-review] pjsip/basic_calls: Add a few more nominal and off nominal basic calls... (...testsuite[16])

[George Joseph]

George Joseph has posted comments on this change. ( https://gerrit.asterisk.org/c/testsuite/+/11567 )

Change subject: pjsip/basic_calls: Add a few more nominal and off nominal basic calls tests
......................................................................


Patch Set 4: Code-Review-1

(2 comments)

https://gerrit.asterisk.org/#/c/11567/4/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_anonymous/test-config.yaml 
File tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_anonymous/test-config.yaml:

https://gerrit.asterisk.org/#/c/11567/4/tests/channels/pjsip/basic_calls/incoming/nominal/unauthed/ident_by_anonymous/test-config.yaml@1 
PS4, Line 1: testinfo:
Do we need a test to ensure that if the "anonymous" identify module isn't loaded an anonymous call will fail?


https://gerrit.asterisk.org/#/c/11567/4/tests/channels/pjsip/basic_calls/outgoing/off-nominal/bob_is_busy_at/test-config.yaml 
File tests/channels/pjsip/basic_calls/outgoing/off-nominal/bob_is_busy_at/test-config.yaml:

https://gerrit.asterisk.org/#/c/11567/4/tests/channels/pjsip/basic_calls/outgoing/off-nominal/bob_is_busy_at/test-config.yaml@1 
PS4, Line 1: testinfo:
I must be missing something.  I don't see the second originate.

Why not just have 2 sipp scenarios that call bob.  one expecting to succeed and one expecting to fail?



-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/11567
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: 16
Gerrit-Change-Id: Iae9854ea496d7241c1a4f9cd551be2ca1fb01078
Gerrit-Change-Number: 11567
Gerrit-PatchSet: 4
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Reviewer: George Joseph <gjoseph at digium.com>
Gerrit-Comment-Date: Fri, 19 Jul 2019 12:22:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190719/df23395f/attachment-0001.html>