[Asterisk-code-review] pjsip/basic_calls: Add a few more nominal and off nominal basic calls... (...testsuite[master])

[Benjamin Keith Ford]

Benjamin Keith Ford has posted comments on this change. ( https://gerrit.asterisk.org/c/testsuite/+/11566 )

Change subject: pjsip/basic_calls: Add a few more nominal and off nominal basic calls tests
......................................................................


Patch Set 2:

(1 comment)

All tests pass and look good to me, just one suggestion, which is minor.

https://gerrit.asterisk.org/#/c/11566/2/tests/channels/pjsip/basic_calls/outgoing/nominal/from_user/configs/ast1/sip.conf 
File tests/channels/pjsip/basic_calls/outgoing/nominal/from_user/configs/ast1/sip.conf:

https://gerrit.asterisk.org/#/c/11566/2/tests/channels/pjsip/basic_calls/outgoing/nominal/from_user/configs/ast1/sip.conf@1 
PS2, Line 1: [general]
           : bindaddr = 127.0.0.1
           : directmedia=no
           : 
           : [uas]
           : type=peer
           : host=127.0.0.1
           : port=5061
           : fromuser=banana
Should this be done via PJSIP to make channel drivers consistent?



-- 
To view, visit https://gerrit.asterisk.org/c/testsuite/+/11566
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: testsuite
Gerrit-Branch: master
Gerrit-Change-Id: Iae9854ea496d7241c1a4f9cd551be2ca1fb01078
Gerrit-Change-Number: 11566
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Friendly Automation
Gerrit-Comment-Date: Thu, 18 Jul 2019 18:29:00 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190718/e8702cc0/attachment.html>