<p style="white-space: pre-wrap; word-wrap: break-word;">All tests pass and look good to me, just one suggestion, which is minor.</p><p><a href="https://gerrit.asterisk.org/c/testsuite/+/11566">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/11566/2/tests/channels/pjsip/basic_calls/outgoing/nominal/from_user/configs/ast1/sip.conf">File tests/channels/pjsip/basic_calls/outgoing/nominal/from_user/configs/ast1/sip.conf:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/11566/2/tests/channels/pjsip/basic_calls/outgoing/nominal/from_user/configs/ast1/sip.conf@1">Patch Set #2, Line 1:</a> </p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;"><pre style="font-family: monospace,monospace; white-space: pre-wrap;">[general]<br>bindaddr = 127.0.0.1<br>directmedia=no<br><br>[uas]<br>type=peer<br>host=127.0.0.1<br>port=5061<br>fromuser=banana<br></pre></blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Should this be done via PJSIP to make channel drivers consistent?</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/c/testsuite/+/11566">change 11566</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/c/testsuite/+/11566"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: testsuite </div>
<div style="display:none"> Gerrit-Branch: master </div>
<div style="display:none"> Gerrit-Change-Id: Iae9854ea496d7241c1a4f9cd551be2ca1fb01078 </div>
<div style="display:none"> Gerrit-Change-Number: 11566 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Benjamin Keith Ford <bford@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 18 Jul 2019 18:29:00 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-Has-Labels: No </div>
<div style="display:none"> Gerrit-MessageType: comment </div>