[Asterisk-code-review] manager channels: Fix throwing of HangupHandler manager events (asterisk[16])

[Joshua C. Colp]

Joshua C. Colp has submitted this change and it was merged. ( https://gerrit.asterisk.org/10911 )

Change subject: manager_channels: Fix throwing of HangupHandler manager events
......................................................................

manager_channels: Fix throwing of HangupHandler manager events

The type value extracted from stasis message data in channel_hangup_handler_cb
isn't compared against the valid values "run", "pop" and "push". Thus the
manager events HangupHandlerPush, HangupHandlerPop and HangupHandlerRun are
never thrown.

This regression was introduced by ASTERISK_21462.

ASTERISK-28252

Change-Id: I9956e35e18da1873113644df1ddc3c7cd37bf524
---
M main/manager_channels.c
1 file changed, 3 insertions(+), 3 deletions(-)

Approvals:
  Richard Mudgett: Looks good to me, but someone else must approve
  Sean Bright: Looks good to me, approved
  Joshua C. Colp: Approved for Submit



diff --git a/main/manager_channels.c b/main/manager_channels.c
index ac09d42..7263386 100644
--- a/main/manager_channels.c
+++ b/main/manager_channels.c
@@ -988,11 +988,11 @@
 		return;
 	}
 
-	if (!strcmp(action, "type")) {
+	if (!strcmp(action, "run")) {
 		event = "HangupHandlerRun";
-	} else if (!strcmp(action, "type")) {
+	} else if (!strcmp(action, "pop")) {
 		event = "HangupHandlerPop";
-	} else if (!strcmp(action, "type")) {
+	} else if (!strcmp(action, "push")) {
 		event = "HangupHandlerPush";
 	} else {
 		return;

-- 
To view, visit https://gerrit.asterisk.org/10911
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 16
Gerrit-MessageType: merged
Gerrit-Change-Id: I9956e35e18da1873113644df1ddc3c7cd37bf524
Gerrit-Change-Number: 10911
Gerrit-PatchSet: 2
Gerrit-Owner: Gerald Schnabel <gs at starface.de>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190123/3eb4f781/attachment-0001.html>