<p>Joshua C. Colp <strong>merged</strong> this change.</p><p><a href="https://gerrit.asterisk.org/10911">View Change</a></p><div style="white-space:pre-wrap">Approvals:
  Richard Mudgett: Looks good to me, but someone else must approve
  Sean Bright: Looks good to me, approved
  Joshua C. Colp: Approved for Submit

</div><pre style="font-family: monospace,monospace; white-space: pre-wrap;">manager_channels: Fix throwing of HangupHandler manager events<br><br>The type value extracted from stasis message data in channel_hangup_handler_cb<br>isn't compared against the valid values "run", "pop" and "push". Thus the<br>manager events HangupHandlerPush, HangupHandlerPop and HangupHandlerRun are<br>never thrown.<br><br>This regression was introduced by ASTERISK_21462.<br><br>ASTERISK-28252<br><br>Change-Id: I9956e35e18da1873113644df1ddc3c7cd37bf524<br>---<br>M main/manager_channels.c<br>1 file changed, 3 insertions(+), 3 deletions(-)<br><br></pre><pre style="font-family: monospace,monospace; white-space: pre-wrap;"><span>diff --git a/main/manager_channels.c b/main/manager_channels.c</span><br><span>index ac09d42..7263386 100644</span><br><span>--- a/main/manager_channels.c</span><br><span>+++ b/main/manager_channels.c</span><br><span>@@ -988,11 +988,11 @@</span><br><span>          return;</span><br><span>      }</span><br><span> </span><br><span style="color: hsl(0, 100%, 40%);">-   if (!strcmp(action, "type")) {</span><br><span style="color: hsl(120, 100%, 40%);">+      if (!strcmp(action, "run")) {</span><br><span>              event = "HangupHandlerRun";</span><br><span style="color: hsl(0, 100%, 40%);">-   } else if (!strcmp(action, "type")) {</span><br><span style="color: hsl(120, 100%, 40%);">+       } else if (!strcmp(action, "pop")) {</span><br><span>               event = "HangupHandlerPop";</span><br><span style="color: hsl(0, 100%, 40%);">-   } else if (!strcmp(action, "type")) {</span><br><span style="color: hsl(120, 100%, 40%);">+       } else if (!strcmp(action, "push")) {</span><br><span>              event = "HangupHandlerPush";</span><br><span>       } else {</span><br><span>             return;</span><br><span></span><br></pre><p>To view, visit <a href="https://gerrit.asterisk.org/10911">change 10911</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/10911"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 16 </div>
<div style="display:none"> Gerrit-MessageType: merged </div>
<div style="display:none"> Gerrit-Change-Id: I9956e35e18da1873113644df1ddc3c7cd37bf524 </div>
<div style="display:none"> Gerrit-Change-Number: 10911 </div>
<div style="display:none"> Gerrit-PatchSet: 2 </div>
<div style="display:none"> Gerrit-Owner: Gerald Schnabel <gs@starface.de> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation (1000185) </div>
<div style="display:none"> Gerrit-Reviewer: Joshua C. Colp <jcolp@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean.bright@gmail.com> </div>