[Asterisk-code-review] res stasis: Auto-create context and add ability to switch ap... (asterisk[13])

[Joshua C. Colp]

Joshua C. Colp has posted comments on this change. ( https://gerrit.asterisk.org/10882 )

Change subject: res_stasis: Auto-create context and add ability to switch applications.
......................................................................


Patch Set 4:

(2 comments)

https://gerrit.asterisk.org/#/c/10882/4/res/stasis/app.c
File res/stasis/app.c:

https://gerrit.asterisk.org/#/c/10882/4/res/stasis/app.c@1029
PS4, Line 1029: 			ast_log(LOG_WARNING, "Could not find or create context '%s'\n", context_name);
> Such as which application this is being done for? That was the only detail that popped into my head. […]
Yes.


https://gerrit.asterisk.org/#/c/10882/4/res/stasis/control.c
File res/stasis/control.c:

https://gerrit.asterisk.org/#/c/10882/4/res/stasis/control.c@1401
PS4, Line 1401: 	control->app = ao2_bump(app);
> Perhaps this should unref the current app if there is one already there? Or should reference managem […]
It should be the responsibility of this function to "do the right thing"



-- 
To view, visit https://gerrit.asterisk.org/10882
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6c569468472dbb08905b356887373c81e03015d
Gerrit-Change-Number: 10882
Gerrit-PatchSet: 4
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Comment-Date: Mon, 21 Jan 2019 15:56:08 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190121/979141ed/attachment.html>