[Asterisk-code-review] res stasis: Auto-create context and add ability to switch ap... (asterisk[13])

[Benjamin Keith Ford]

Benjamin Keith Ford has posted comments on this change. ( https://gerrit.asterisk.org/10882 )

Change subject: res_stasis: Auto-create context and add ability to switch applications.
......................................................................


Patch Set 4:

(2 comments)

https://gerrit.asterisk.org/#/c/10882/4/res/stasis/app.c
File res/stasis/app.c:

https://gerrit.asterisk.org/#/c/10882/4/res/stasis/app.c@1029
PS4, Line 1029: 			ast_log(LOG_WARNING, "Could not find or create context '%s'\n", context_name);
> I'd extend this warning to include details about the application too
Such as which application this is being done for? That was the only detail that popped into my head. Also noticed I need to change the WARNING to just "could not create" too, since there's a search to see if it exists or not already.


https://gerrit.asterisk.org/#/c/10882/4/res/stasis/control.c
File res/stasis/control.c:

https://gerrit.asterisk.org/#/c/10882/4/res/stasis/control.c@1401
PS4, Line 1401: 	control->app = ao2_bump(app);
> What if there's an existing app here?
Perhaps this should unref the current app if there is one already there? Or should reference management be left to the caller of the function?



-- 
To view, visit https://gerrit.asterisk.org/10882
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib6c569468472dbb08905b356887373c81e03015d
Gerrit-Change-Number: 10882
Gerrit-PatchSet: 4
Gerrit-Owner: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: Joshua C. Colp <jcolp at digium.com>
Gerrit-Comment-Date: Mon, 21 Jan 2019 15:53:59 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190121/a8b770f6/attachment.html>