[Asterisk-code-review] sched: Make sched settime() return void because it cannot fail (asterisk[13])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/10883 )

Change subject: sched: Make sched_settime() return void because it cannot fail
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/10883/1/main/sched.c
File main/sched.c:

https://gerrit.asterisk.org/#/c/10883/1/main/sched.c@500
PS1, Line 500: 		ast_assert(0);
> Would it be better to `return -1` here?  2^31 ms is 25 days, is that ever valid?
Looking back I wonder why this just wasn't a single assert:

ast_assert(when < 0)

As no real need for the warning and runtime check outside dev mode. Or why not just make 'when' an unsigned int to start?

Anyhoo valid? possibly, but used (or would be)? doubtful. I'm good either way.



-- 
To view, visit https://gerrit.asterisk.org/10883
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I66b8b2b2778f186919d73ae9bf592104b8fb1cd5
Gerrit-Change-Number: 10883
Gerrit-PatchSet: 1
Gerrit-Owner: Sean Bright <sean.bright at gmail.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Richard Mudgett <rmudgett at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Thu, 17 Jan 2019 19:20:01 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190117/2037ca2f/attachment.html>