<p><a href="https://gerrit.asterisk.org/10883">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10883/1/main/sched.c">File main/sched.c:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10883/1/main/sched.c@500">Patch Set #1, Line 500:</a> <code style="font-family:monospace,monospace">            ast_assert(0);</code></p><p><blockquote style="border-left: 1px solid #aaa; margin: 10px 0; padding: 0 10px;">Would it be better to `return -1` here?  2^31 ms is 25 days, is that ever valid?</blockquote></p><p style="white-space: pre-wrap; word-wrap: break-word;">Looking back I wonder why this just wasn't a single assert:</p><p style="white-space: pre-wrap; word-wrap: break-word;">ast_assert(when < 0)</p><p style="white-space: pre-wrap; word-wrap: break-word;">As no real need for the warning and runtime check outside dev mode. Or why not just make 'when' an unsigned int to start?</p><p style="white-space: pre-wrap; word-wrap: break-word;">Anyhoo valid? possibly, but used (or would be)? doubtful. I'm good either way.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/10883">change 10883</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/10883"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: I66b8b2b2778f186919d73ae9bf592104b8fb1cd5 </div>
<div style="display:none"> Gerrit-Change-Number: 10883 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation (1000185) </div>
<div style="display:none"> Gerrit-Reviewer: Kevin Harwell <kharwell@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Richard Mudgett <rmudgett@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Sean Bright <sean.bright@gmail.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 17 Jan 2019 19:20:01 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>