[Asterisk-code-review] pjsip/config global: regcontext context not created (asterisk[13])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/10879 )

Change subject: pjsip/config_global: regcontext context not created
......................................................................


Patch Set 2:

> > chan_sip uses registrar "SIP".  I feel like this should be
 > "PJSIP" (or maybe just AST_MODULE would be better).
 > 
 > I thought about this, but when the extension is added for
 > regcontext in 'ast_sip_persistent_endpoint_update_state' the
 > registrar is "SIP", so I set it to this to be consistent with that.
 > 
 > But I'm fine with changing it. If I change it to "PJSIP" or
 > AST_MODULE should I go ahead and alter the one at add time too?

I think no part of the PJSIP system should use the same dialplan registrar as chan_sip.  So my preference is that ast_sip_persistent_endpoint_update_state should change.


-- 
To view, visit https://gerrit.asterisk.org/10879
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f36cf4ab0a93ff4b1cc5548d617ecfd45e09265
Gerrit-Change-Number: 10879
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Wed, 16 Jan 2019 18:50:43 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190116/81c3085f/attachment.html>