[Asterisk-code-review] pjsip/config global: regcontext context not created (asterisk[13])

[Kevin Harwell]

Kevin Harwell has posted comments on this change. ( https://gerrit.asterisk.org/10879 )

Change subject: pjsip/config_global: regcontext context not created
......................................................................


Patch Set 2:

> chan_sip uses registrar "SIP".  I feel like this should be "PJSIP" (or maybe just AST_MODULE would be better).

I thought about this, but when the extension is added for regcontext in 'ast_sip_persistent_endpoint_update_state' the registrar is "SIP", so I set it to this to be consistent with that.

But I'm fine with changing it. If I change it to "PJSIP" or AST_MODULE should I go ahead and alter the one at add time too? 

> Do we need an ast_context_destroy_by_name anywhere to balance this?  Probably not a crash risk if we don't since we never run 'dlclose' on res_pjsip.so but I still feel like asking.  Have you tested what happens if someone changes the regcontext then reloads?

Good catch! Not sure I didn't test that actually. It certainly can't hurt. I'll add and test.


-- 
To view, visit https://gerrit.asterisk.org/10879
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: I0f36cf4ab0a93ff4b1cc5548d617ecfd45e09265
Gerrit-Change-Number: 10879
Gerrit-PatchSet: 2
Gerrit-Owner: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Benjamin Keith Ford <bford at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: Kevin Harwell <kharwell at digium.com>
Gerrit-Reviewer: Sean Bright <sean.bright at gmail.com>
Gerrit-Comment-Date: Wed, 16 Jan 2019 18:44:29 +0000
Gerrit-HasComments: No
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190116/3dc71de4/attachment.html>