[Asterisk-code-review] stasis/endpoint: Fix memory leak of channel ids in ast endpo... (asterisk[13])

[Corey Farrell]

Corey Farrell has posted comments on this change. ( https://gerrit.asterisk.org/10859 )

Change subject: stasis/endpoint: Fix memory leak of channel_ids in ast_endpoint structure.
......................................................................


Patch Set 1:

(1 comment)

https://gerrit.asterisk.org/#/c/10859/1/include/asterisk/channel.h
File include/asterisk/channel.h:

https://gerrit.asterisk.org/#/c/10859/1/include/asterisk/channel.h@2601
PS1, Line 2601: void ast_channel_internal_swap_endpoint_forward_and_endpoint_cache_forward(struct ast_channel *a, struct ast_channel *b);
Would it be better if this were exposed by channel_internal.h?  I might even go a step farther and suggest maybe it should not have the 'ast_' prefer?  Naming it channel_internal_swap_endpoint_forward_and_endpoint_cache_forward would block modules from linking to this function.

I know other functions right above are in the same situation so I'm not giving -1 but I think it's worth asking.



-- 
To view, visit https://gerrit.asterisk.org/10859
To unsubscribe, or for help writing mail filters, visit https://gerrit.asterisk.org/settings

Gerrit-Project: asterisk
Gerrit-Branch: 13
Gerrit-MessageType: comment
Gerrit-Change-Id: Ied0451f378a3f2a36acc8c0984959a69895efa17
Gerrit-Change-Number: 10859
Gerrit-PatchSet: 1
Gerrit-Owner: Mohit Dhiman <mohitdhiman at drishti-soft.com>
Gerrit-Reviewer: Chris Savinovich <csavinovich at digium.com>
Gerrit-Reviewer: Corey Farrell <git at cfware.com>
Gerrit-Reviewer: Friendly Automation (1000185)
Gerrit-Reviewer: Mohit Dhiman <mohitdhiman at drishti-soft.com>
Gerrit-Comment-Date: Thu, 10 Jan 2019 15:54:39 +0000
Gerrit-HasComments: Yes
Gerrit-HasLabels: No
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.digium.com/pipermail/asterisk-code-review/attachments/20190110/7678441e/attachment.html>