<p><a href="https://gerrit.asterisk.org/10859">View Change</a></p><p>1 comment:</p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0;"><p><a href="https://gerrit.asterisk.org/#/c/10859/1/include/asterisk/channel.h">File include/asterisk/channel.h:</a></p><ul style="list-style: none; padding: 0;"><li style="margin: 0; padding: 0 0 0 16px;"><p style="margin-bottom: 4px;"><a href="https://gerrit.asterisk.org/#/c/10859/1/include/asterisk/channel.h@2601">Patch Set #1, Line 2601:</a> <code style="font-family:monospace,monospace">void ast_channel_internal_swap_endpoint_forward_and_endpoint_cache_forward(struct ast_channel *a, struct ast_channel *b);</code></p><p style="white-space: pre-wrap; word-wrap: break-word;">Would it be better if this were exposed by channel_internal.h?  I might even go a step farther and suggest maybe it should not have the 'ast_' prefer?  Naming it channel_internal_swap_endpoint_forward_and_endpoint_cache_forward would block modules from linking to this function.</p><p style="white-space: pre-wrap; word-wrap: break-word;">I know other functions right above are in the same situation so I'm not giving -1 but I think it's worth asking.</p></li></ul></li></ul><p>To view, visit <a href="https://gerrit.asterisk.org/10859">change 10859</a>. To unsubscribe, or for help writing mail filters, visit <a href="https://gerrit.asterisk.org/settings">settings</a>.</p><div itemscope itemtype="http://schema.org/EmailMessage"><div itemscope itemprop="action" itemtype="http://schema.org/ViewAction"><link itemprop="url" href="https://gerrit.asterisk.org/10859"/><meta itemprop="name" content="View Change"/></div></div>

<div style="display:none"> Gerrit-Project: asterisk </div>
<div style="display:none"> Gerrit-Branch: 13 </div>
<div style="display:none"> Gerrit-MessageType: comment </div>
<div style="display:none"> Gerrit-Change-Id: Ied0451f378a3f2a36acc8c0984959a69895efa17 </div>
<div style="display:none"> Gerrit-Change-Number: 10859 </div>
<div style="display:none"> Gerrit-PatchSet: 1 </div>
<div style="display:none"> Gerrit-Owner: Mohit Dhiman <mohitdhiman@drishti-soft.com> </div>
<div style="display:none"> Gerrit-Reviewer: Chris Savinovich <csavinovich@digium.com> </div>
<div style="display:none"> Gerrit-Reviewer: Corey Farrell <git@cfware.com> </div>
<div style="display:none"> Gerrit-Reviewer: Friendly Automation (1000185) </div>
<div style="display:none"> Gerrit-Reviewer: Mohit Dhiman <mohitdhiman@drishti-soft.com> </div>
<div style="display:none"> Gerrit-Comment-Date: Thu, 10 Jan 2019 15:54:39 +0000 </div>
<div style="display:none"> Gerrit-HasComments: Yes </div>
<div style="display:none"> Gerrit-HasLabels: No </div>